lkml.org 
[lkml]   [2020]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies
From
Date

On 9/3/20 5:55 AM, Jacopo Mondi wrote:
> Hello Sowjanya,
>
> On Tue, Sep 01, 2020 at 07:04:37PM -0700, Sowjanya Komatineni wrote:
>> This patch adds IMX274 optional external clock input and voltage
>> supplies to device tree bindings.
>>
>> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>> .../devicetree/bindings/media/i2c/sony,imx274.yaml | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>> index 7ae47a6..57e7176 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>> @@ -25,6 +25,27 @@ properties:
>> reset-gpios:
>> maxItems: 1
>>
> I just sent an update to my json-schema conversion of this bindings
> document (not yet on patchwork, sorry) and Sakari pointed me to the
> fact in between my v2 and my v4 this patch from you went in:
> 4ea3273d24b ("dt-bindings: media: imx274: Add optional input clock and supplies")
>
> I should probably now update my bindings conversion patch, basically
> taking in what you've done here, but I would have one question.
>
>> + clocks:
>> + maxItems: 1
>> + description: Reference to the sensor input clock
>> +
>> + clock-names:
>> + maxItems: 1
>> + items:
>> + - const: inck
>> +
>> + vana-supply:
>> + description:
>> + Analog voltage supply, 2.8 volts
>> +
>> + vdig-supply:
>> + description:
>> + Digital IO voltage supply, 1.8 volts
>> +
>> + vddl-supply:
>> + description:
>> + Digital core voltage supply, 1.2 volts
> 4ea3273d24b introduced these regulators as VANA-supply, VDIG-supply
> and VDDL-supply (please note the upper-case names). This version uses
> lower-case ones instead. Is this intentional ? The driver currently
> does not parse any of these if I'm not mistaken, but as the bindings
> in textual form defines an ABI which should be preserved during the
> conversion to json-schema, should these be kept in upper-case ?
>
> Thanks
> j

Yes, based on feedback lower case was recommended. So, changed to use
lower-case names.

These properties were not used by driver currently and from my prior
series only dt-binding got merged as  no feedback was received on it for
all prior versions.

So, should be ok to change to lower-case as there properties are
introduced now and driver update using these properties is under review

>> +
>> port:
>> type: object
>> description: |
>> --
>> 2.7.4
>>

\
 
 \ /
  Last update: 2020-09-03 18:06    [W:0.090 / U:31.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site