[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 00/30] spi: dw: Add full Baikal-T1 SPI Controllers support
On Sun, Sep 20, 2020 at 02:28:44PM +0300, Serge Semin wrote:

> First two patches are just cleanups to simplify the DW APB SSI device
> initialization a bit. We suggest to discard the IRQ threshold macro as
> unused and use a ternary operator to initialize the set_cs callback
> instead of assigning-and-updating it.

> Then we've discovered that the n_bytes field of the driver private data is
> used by the DW APB SSI IRQ handler, which requires it to be initialized

This is a *huge* patch series which is a bit unweildy to review
(especially given the other 10+ patch series you sent at the same time),
once you start getting over 10 patches it's time to pay attention to
series length and the fact that you're outlining a bunch of tangentially
related areas which could have been split out easily enough. It is much
better to send smaller sets of patches at once, or if you're sending a
lot then to split them into smaller serieses. This will tend to make
the review more approachable which will in turn tend to make things go
faster, people are much more likely to put off going through a huge
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2020-09-29 16:45    [W:0.355 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site