lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/30] spi: dw: Use ternary op to init set_cs callback
On Sun, Sep 20, 2020 at 02:28:46PM +0300, Serge Semin wrote:
> Simplify the dw_spi_add_host() method a bit by replacing the set_cs
> callback overwrite procedure with direct setting the callback if a custom
> version of one is specified.

> - master->set_cs = dw_spi_set_cs;
> + master->set_cs = dws->set_cs ?: dw_spi_set_cs;

> - if (dws->set_cs)
> - master->set_cs = dws->set_cs;

This doesn't look like a win for legibility or comprehensibility.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-29 15:13    [W:0.224 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site