Messages in this thread Patch in this message |  | | From | "Zhao, Haifeng" <> | Subject | RE: [PATCH 4/5 V2] PCI: only return true when dev io state is really changed | Date | Sun, 27 Sep 2020 05:12:23 +0000 |
| |
😊 definitely simpler !
-----Original Message----- From: Joe Perches <joe@perches.com> Sent: Sunday, September 27, 2020 12:17 PM To: Zhao, Haifeng <haifeng.zhao@intel.com>; bhelgaas@google.com; oohall@gmail.com; ruscur@russell.cc; lukas@wunner.de; andriy.shevchenko@linux.intel.com; stuart.w.hayes@gmail.com; mr.nuke.me@gmail.com; mika.westerberg@linux.intel.com Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; Jia, Pei P <pei.p.jia@intel.com>; ashok.raj@linux.intel.com; Kuppuswamy, Sathyanarayanan <sathyanarayanan.kuppuswamy@intel.com> Subject: Re: [PATCH 4/5 V2] PCI: only return true when dev io state is really changed
On Sat, 2020-09-26 at 23:28 -0400, Ethan Zhao wrote: > simplify the pci_dev_set_io_state() function to only return true when > dev->error_state is changed. [] > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h [] > @@ -362,35 +362,11 @@ static inline bool pci_dev_set_io_state(struct pci_dev *dev, > bool changed = false; [] > + if (dev->error_state == new) > + return changed; > + > + dev->error_state = new; > + changed = true; > return changed; > }
This would be simpler removing the unnecessary changed automatic
...
if (dev->error_state == new) return false;
dev->error_state = new;
return true; }
|  |