lkml.org 
[lkml]   [2020]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] bus: mhi: core: debugfs: Use correct format specifiers for addresses
On Sun, Sep 27, 2020 at 12:23:10PM +0200, Greg KH wrote:
> On Sun, Sep 27, 2020 at 09:06:48AM +0530, Manivannan Sadhasivam wrote:
> > For exposing the addresses of read/write pointers and doorbell register,
> > let's use the correct format specifiers. This fixes the following issues
> > generated using W=1 build in ARM32 and reported by Kbuild bot:
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/bus/mhi/core/debugfs.c:75:7: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
> > mhi_event->db_cfg.db_val);
> > ^~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/bus/mhi/core/debugfs.c:123:7: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
> > mhi_chan->db_cfg.db_val);
> > ^~~~~~~~~~~~~~~~~~~~~~~
> > 2 warnings generated.
> >
> > drivers/bus/mhi/core/debugfs.c: In function ‘mhi_debugfs_events_show’:
> > drivers/bus/mhi/core/debugfs.c:74:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> > seq_printf(m, " local rp: 0x%llx db: 0x%pad\n", (u64)ring->rp,
> > ^
> > drivers/bus/mhi/core/debugfs.c: In function ‘mhi_debugfs_channels_show’:
> > drivers/bus/mhi/core/debugfs.c:122:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> > (u64)ring->rp, (u64)ring->wp,
> > ^
> > drivers/bus/mhi/core/debugfs.c:122:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> > (u64)ring->rp, (u64)ring->wp,
> > ^
> > drivers/bus/mhi/core/debugfs.c:121:62: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘dma_addr_t {aka unsigned int}’ [-Wformat=]
> > seq_printf(m, " local rp: 0x%llx local wp: 0x%llx db: 0x%llx\n",
> > ~~~^
> > %x
> > drivers/bus/mhi/core/debugfs.c:123:7:
> > mhi_chan->db_cfg.db_val);
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > drivers/bus/mhi/core/debugfs.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
>
> Ah, this is against your first set of patches, that's the confusion on
> my part.
>
> Please just fix them all up and resend 1 series of patches, that isn't
> broken, and I will be glad to review and take that.
>

Sure, will merge this patch with debugfs one. I submitted this patch as I got
error report from Kbuild bot and I thought you applied the series to
char-misc-testing branch.

Thanks,
Mani

> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2020-09-28 05:48    [W:0.069 / U:2.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site