[lkml]   [2020]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch 19/35] net: zd1211rw: Remove ZD_ASSERT(in_interrupt())
From: Sebastian Andrzej Siewior <>

in_interrupt() is ill defined and does not provide what the name
suggests. The usage especially in driver code is deprecated and
a tree wide effort to clean up and consolidate the (ab)usage of
in_interrupt() and related checks is happening.

handle_regs_int() is always invoked as part of URB callback which is either
invoked from hard or soft interrupt context.

Remove the magic assertion.

Signed-off-by: Sebastian Andrzej Siewior <>
Signed-off-by: Thomas Gleixner <>
Cc: Daniel Drake <>
Cc: Ulrich Kunitz <>
Cc: Kalle Valo <>
Cc: "David S. Miller" <>
Cc: Jakub Kicinski <>

drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
+++ b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
@@ -378,7 +378,6 @@ static inline void handle_regs_int(struc
int len;
u16 int_num;

- ZD_ASSERT(in_interrupt());
spin_lock_irqsave(&intr->lock, flags);

int_num = le16_to_cpu(*(__le16 *)(urb->transfer_buffer+2));
 \ /
  Last update: 2020-09-27 22:00    [W:0.194 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site