[lkml]   [2020]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch 07/35] net: cxbg4: Remove pointless in_interrupt() check
From: Thomas Gleixner <>

t4_sge_stop() is only ever called from task context and the in_interrupt()
check is presumably a leftover from copying t3_sge_stop().

Aside of in_interrupt() being deprecated because it's not providing what it
claims to provide, this check would paper over illegitimate callers.

The functions invoked from t4_sge_stop() contain already warnings to catch
invocations from invalid contexts.

Remove it.

Signed-off-by: Thomas Gleixner <>
Cc: Vishal Kulkarni <>
Cc: "David S. Miller" <>
Cc: Jakub Kicinski <>

drivers/net/ethernet/chelsio/cxgb4/sge.c | 3 ---
1 file changed, 3 deletions(-)

--- a/drivers/net/ethernet/chelsio/cxgb4/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c
@@ -4872,9 +4872,6 @@ void t4_sge_stop(struct adapter *adap)
int i;
struct sge *s = &adap->sge;

- if (in_interrupt()) /* actions below require waiting */
- return;
if (s->rx_timer.function)
if (s->tx_timer.function)
 \ /
  Last update: 2020-09-27 21:58    [W:0.240 / U:2.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site