lkml.org 
[lkml]   [2020]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] nvmem: core: fix possibly memleak when use nvmem_cell_info_to_nvmem_cell()
On Fri, Sep 25, 2020 at 10:32:42AM +0100, Srinivas Kandagatla wrote:
>
>
> On 23/09/2020 21:44, Vadym Kochan wrote:
> > Fix missing 'kfree_const(cell->name)' when call to
> > nvmem_cell_info_to_nvmem_cell() in several places:
> >
> > * after nvmem_cell_info_to_nvmem_cell() failed during
> > nvmem_add_cells()
> >
> > * during nvmem_device_cell_{read,write} when cell->name is
> > kstrdup'ed() without calling kfree_const() at the end, but
> > really there is no reason to do that 'dup, because the cell
> > instance is allocated on the stack for some short period to be
> > read/write without exposing it to the caller.
> >
> > So the new nvmem_cell_info_to_nvmem_cell_nodup() helper is introduced
> > which is used to convert cell_info -> cell without name duplication as
> > a lighweight version of nvmem_cell_info_to_nvmem_cell().
> >
> > Fixes: e2a5402ec7c6 ("nvmem: Add nvmem_device based consumer apis.")
> > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
>
> Looks good to me! Thanks for the patch.
>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> Greg,
>
> Can you please pick this one? As don't have any nvmem pending patches to
> send it together.

Will do, thanks.

greg k-h

\
 
 \ /
  Last update: 2020-09-27 14:27    [W:0.036 / U:30.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site