lkml.org 
[lkml]   [2020]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] mic: vop: fix a written error in MODULE_DEVICE_TABLE
On Fri, Sep 25, 2020 at 03:31:56PM +0800, Sherry Sun wrote:
> For vop bus, the first parameter should be vop in MODULE_DEVICE_TABLE.
>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> ---
> drivers/misc/mic/vop/vop_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c
> index d609f0dc6124..589425fa78d4 100644
> --- a/drivers/misc/mic/vop/vop_main.c
> +++ b/drivers/misc/mic/vop/vop_main.c
> @@ -796,7 +796,7 @@ static struct vop_driver vop_driver = {
>
> module_vop_driver(vop_driver);
>
> -MODULE_DEVICE_TABLE(mbus, id_table);
> +MODULE_DEVICE_TABLE(vop, id_table);
> MODULE_AUTHOR("Intel Corporation");
> MODULE_DESCRIPTION("Intel(R) Virtio Over PCIe (VOP) driver");
> MODULE_LICENSE("GPL v2");

Doesn't this have to go _after_ the MODULE_DEVICE_TABLE(vop...) support,
which you add in patch 2 of this series?

Does this patch here break the build? If not, how is it working?

And if you only have one vop driver, why do you need autoloading for it?

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-09-27 12:28    [W:0.076 / U:2.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site