Messages in this thread |  | | From | Jerome Brunet <> | Subject | Re: [PATCH 8/8] arm64: dts: meson: enable RTC for VIM2 meson-gxm-khadas-vim2 | Date | Fri, 25 Sep 2020 10:58:00 +0200 |
| |
On Fri 25 Sep 2020 at 05:30, Artem Lapkin <email2tema@gmail.com> wrote:
> enable RTC for VIM2 meson-gxm-khadas-vim2 > > Signed-off-by: Artem Lapkin <art@khadas.com> > --- > arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts > index 70343da2811..76b7e34a9a3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts > @@ -229,7 +229,7 @@ &i2c_B { > > rtc: rtc@51 { > /* has to be enabled manually when a battery is connected: */
If going for this change, this comment should have been removed
> - status = "disabled"; > + status = "okay";
Unless the VIMs are provided with a battery by default, I believe this should be kept disabled and only enabled by the bootloader if necessary.
If you think differently, feel free to resubmit with a complete commit description and some details as to how this would be an improvement.
> compatible = "haoyu,hym8563"; > reg = <0x51>; > #clock-cells = <0>;
|  |