lkml.org 
[lkml]   [2020]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20
On Thu, Sep 24, 2020 at 11:04:51PM +0800, cy_huang wrote:

> + enable-gpio:
> + description: A connection of the 'enable' gpio line.
> + maxItems: 1

-gpios. GPIO properties should always be plural even if there's only
one GPIO.

> + ld_pulse_delay:

Properties should use - not _ and for all the properties specifying
things like times you should have units so...

> + description: |
> + load current pulse delay in microsecond after strobe pin pulse high.
> + $ref: "/schemas/types.yaml#/definitions/uint32"

...add -us here.

> + fsin_enable:
> + description: Fsin function enable control.
> + $ref: "/schemas/types.yaml#/definitions/uint32"
> + minimum: 0
> + maximum: 1
> + default: 0

This looks like it should be a boolean property not a number. The same
is true for most if not all of the other properties with min/max of 0/1.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-24 18:25    [W:0.073 / U:1.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site