lkml.org 
[lkml]   [2020]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] usb: typec: Remove set but not used variable
From
Date
On 9/24/20 7:12 AM, Li Heng wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/typec/tcpm/tcpm.c:1620:39: warning:
> ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Li Heng <liheng40@huawei.com>

I thought there was a patch series underway which started using it,
but maybe my memory defeats me. Either case, it doesn't make much sense
to remove the ops variable without removing the associated functions
as well.

Guenter

> ---
> drivers/usb/typec/tcpm/tcpm.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 9280654..1542eaa 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -1617,12 +1617,6 @@ static int tcpm_altmode_vdm(struct typec_altmode *altmode,
> return 0;
> }
>
> -static const struct typec_altmode_ops tcpm_altmode_ops = {
> - .enter = tcpm_altmode_enter,
> - .exit = tcpm_altmode_exit,
> - .vdm = tcpm_altmode_vdm,
> -};
> -
> /*
> * PD (data, control) command handling functions
> */
> --
> 2.7.4
>


\
 
 \ /
  Last update: 2020-09-24 16:34    [W:0.055 / U:2.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site