lkml.org 
[lkml]   [2020]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/4] dt-bindings: reserved-memory: Document "active" property
From
Date
04.09.2020 15:59, Thierry Reding пишет:
> From: Thierry Reding <treding@nvidia.com>
>
> Reserved memory regions can be marked as "active" if hardware is
> expected to access the regions during boot and before the operating
> system can take control. One example where this is useful is for the
> operating system to infer whether the region needs to be identity-
> mapped through an IOMMU.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../bindings/reserved-memory/reserved-memory.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
> index 4dd20de6977f..163d2927e4fc 100644
> --- a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
> +++ b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
> @@ -63,6 +63,13 @@ reusable (optional) - empty property
> able to reclaim it back. Typically that means that the operating
> system can use that region to store volatile or cached data that
> can be otherwise regenerated or migrated elsewhere.
> +active (optional) - empty property
> + - If this property is set for a reserved memory region, it indicates
> + that some piece of hardware may be actively accessing this region.
> + Should the operating system want to enable IOMMU protection for a
> + device, all active memory regions must have been identity-mapped
> + in order to ensure that non-quiescent hardware during boot can
> + continue to access the memory.
>
> Linux implementation note:
> - If a "linux,cma-default" property is present, then Linux will use the
>

Hi,

Could you please explain what devices need this quirk? I see that you're
targeting Tegra SMMU driver, which means that it should be some pre-T186
device. Is this reservation needed for some device that has display
hardwired to a very specific IOMMU domain at the boot time?

If you're targeting devices that don't have IOMMU enabled by default at
the boot time, then this approach won't work for the existing devices
which won't ever get an updated bootloader. I think Robin Murphy already
suggested that we should simply create a dummy "identity" IOMMU domain
by default for the DRM/VDE devices and then replace it with an
explicitly created domain within the drivers.

Secondly, all NVIDIA bootloaders are passing tegra_fbmem=... via
kernel's cmdline with the physical location of the framebuffer in
memory. Maybe we could support this option?

\
 
 \ /
  Last update: 2020-09-24 15:24    [W:0.224 / U:2.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site