lkml.org 
[lkml]   [2020]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes
Am 2020-09-24 02:35, schrieb Leo Li:
>> -----Original Message-----
>> From: Michael Walle <michael@walle.cc>
>> Sent: Wednesday, September 23, 2020 4:57 AM
>> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
>> linux-
>> kernel@vger.kernel.org; linux-can@vger.kernel.org
>> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
>> Herring <robh+dt@kernel.org>; Marc Kleine-Budde <mkl@pengutronix.de>;
>> Joakim Zhang <qiangqing.zhang@nxp.com>; Michael Walle
>> <michael@walle.cc>
>> Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes
>>
>> The LS1028A has two FlexCAN controller. These are compatible with the
>> ones
>> from the LX2160A. Add the nodes.
>>
>> The first controller was tested on the Kontron sl28 board.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18
>> ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index 0efeb8fa773e..807ee921ec12 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -386,6 +386,24 @@
>> status = "disabled";
>> };
>>
>> + can0: can@2180000 {
>> + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-
>> flexcan";
>
> The explicit compatible strings cannot be found in the binding, but
> matched by the "fsl,<processor>-flexcan" pattern in the binding. Is
> this considered to be acceptable now?

What is the consequence if it is not acceptable? replacing the pattern
with individual compatible strings?

-michael

\
 
 \ /
  Last update: 2020-09-24 13:31    [W:0.082 / U:3.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site