[lkml]   [2020]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4] ide/macide: Convert Mac IDE driver to platform driver
Hi Finn,

On Thu, Sep 24, 2020 at 1:17 AM Finn Thain <> wrote:
> Add platform devices for the Mac IDE controller variants. Convert the
> macide module into a platform driver to support two of those variants.
> For the third, use a generic "pata_platform" driver instead.
> This enables automatic loading of the appropriate module and begins
> the process of replacing the driver with libata alternatives.
> Cc: Bartlomiej Zolnierkiewicz <>
> Cc: Geert Uytterhoeven <>
> Cc: Joshua Thompson <>
> References: commit 5ed0794cde593 ("m68k/atari: Convert Falcon IDE drivers to platform drivers")
> References: commit 7ad19a99ad431 ("ide: officially deprecated the legacy IDE driver")
> Tested-by: Stan Johnson <>
> Signed-off-by: Finn Thain <>
> ---
> This patch was tested successfully on a Powerbook 190 (MAC_IDE_BABOON)
> using both pata_platform and ide_platform drivers.
> The next step will be to try using these generic drivers with the other
> IDE controller variants (MAC_IDE_QUADRA or MAC_IDE_PB) so that the macide
> driver can be entirely replaced with libata drivers.
> Changed since v3:
> - Updated Kconfig help text.
> Changed since v2:
> - Enabled CONFIG_BLK_DEV_PLATFORM in multi_defconfig.
> - Replaced dev_get_drvdata() with platform_get_drvdata().

Thanks for the updates!

Reviewed-by: Geert Uytterhoeven <>
i.e. will queue in the m68k for-v5.10 branch, hopefully with an
Acked-by from the IDE maintainer.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

 \ /
  Last update: 2020-09-24 09:22    [W:0.038 / U:2.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site