[lkml]   [2020]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v6 0/6] irqchip: dw-apb-ictl: support hierarchy irq domain
v5 --> v6:
1. add Reviewed-by: Rob Herring <> for Patch 4.
2. Some modifications are made to Patch 5:
1) add " |" for each "description:" property if its content exceeds one line,
to tell the yaml keep the "newline" character.
2) add "..." to mark the end of the yaml file.
3) Change the name list of maintainers to the author of "snps,dw-apb-ictl.txt"
- - Marc Zyngier <>
+ - Sebastian Hesselbarth <>
4) add "maxItems: 1" for property "reg".
5) for property "interrupts":
- minItems: 1
- maxItems: 65
+ maxItems: 1
6) move below descriptions under the top level property "description:"
description: |
Synopsys DesignWare provides interrupt controller IP for APB known as
dw_apb_ictl. The IP is used as secondary interrupt controller in some SoCs
with APB bus, e.g. Marvell Armada 1500. It can also be used as primary
interrupt controller in some SoCs, e.g. Hisilicon SD5203.

+ The interrupt sources map to the corresponding bits in the interrupt
+ registers, i.e.
+ - 0 maps to bit 0 of low interrupts,
+ - 1 maps to bit 1 of low interrupts,
+ - 32 maps to bit 0 of high interrupts,
+ - 33 maps to bit 1 of high interrupts,
+ - (optional) fast interrupts start at 64.

For more details of 2-6), please refer

v4 --> v5:
1. Add WARN_ON(1) in set_handle_irq() if !GENERIC_IRQ_MULTI_HANDLER
2. Convert "snps,dw-apb-ictl.txt" to "snps,dw-apb-ictl.yaml"
3. Fix the errors detected by "snps,dw-apb-ictl.yaml" on arch/arc

v3 --> v4:
1. remove "gc->chip_types[0].chip.irq_eoi = irq_gc_noop;", the "chip.irq_eoi" hook
is not needed by handle_level_irq(). Thanks for Marc Zyngier's review.
2. Add a new patch: define an empty function set_handle_irq() if !GENERIC_IRQ_MULTI_HANDLER
to avoid compilation error on arch/arc system.

v2 --> v3:
1. change (1 << hwirq) to BIT(hwirq).
2. change __exception_irq_entry to __irq_entry, so we can "#include <linux/interrupt.h>"
instead of "#include <asm/exception.h>". Ohterwise, an compilation error will be
reported on arch/csky.
drivers/irqchip/irq-dw-apb-ictl.c:20:10: fatal error: asm/exception.h: No such file or directory
3. use "if (!parent || (np == parent))" to determine whether it is primary interrupt controller.
4. make the primary interrupt controller case also use function handle_level_irq(), I used
handle_fasteoi_irq() as flow_handler before.
5. Other minor changes are not detailed.

v1 --> v2:
According to Marc Zyngier's suggestion, discard adding an independent SD5203-VIC
driver, but make the dw-apb-ictl irqchip driver to support hierarchy irq domain.
It was originally available only for secondary interrupt controller, now it can
also be used as primary interrupt controller. The related dt-bindings is updated

Add "Suggested-by: Marc Zyngier <>".
Add "Tested-by: Haoyu Lv <>".

The interrupt controller of SD5203 SoC is VIC(vector interrupt controller), it's
based on Synopsys DesignWare APB interrupt controller (dw_apb_ictl) IP, but it
can not directly use dw_apb_ictl driver. The main reason is that VIC is used as
primary interrupt controller and dw_apb_ictl driver worked for secondary
interrupt controller. So add a new driver: "hisilicon,sd5203-vic".

Zhen Lei (6):
genirq: define an empty function set_handle_irq() if
irqchip: dw-apb-ictl: prepare for support hierarchy irq domain
irqchip: dw-apb-ictl: support hierarchy irq domain
dt-bindings: dw-apb-ictl: support hierarchy irq domain
dt-bindings: dw-apb-ictl: convert to json-schema
ARC: [dts] fix the errors detected by dtbs_check

.../interrupt-controller/snps,dw-apb-ictl.txt | 31 --------
.../interrupt-controller/snps,dw-apb-ictl.yaml | 74 +++++++++++++++++++
arch/arc/boot/dts/axc001.dtsi | 2 +-
arch/arc/boot/dts/axc003.dtsi | 2 +-
arch/arc/boot/dts/axc003_idu.dtsi | 2 +-
arch/arc/boot/dts/vdk_axc003.dtsi | 2 +-
arch/arc/boot/dts/vdk_axc003_idu.dtsi | 2 +-
drivers/irqchip/Kconfig | 2 +-
drivers/irqchip/irq-dw-apb-ictl.c | 83 ++++++++++++++++++----
include/linux/irq.h | 6 ++
10 files changed, 157 insertions(+), 49 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.txt
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.yaml


 \ /
  Last update: 2020-09-24 09:19    [W:0.158 / U:5.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site