lkml.org 
[lkml]   [2020]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] drm/ingenic: Add support for 30-bit modes
On Tue, Sep 15, 2020 at 02:38:16PM +0200, Paul Cercueil wrote:
> Starting from the JZ4760 SoC, the primary and overlay planes support
> 30-bit pixel modes (10 bits per color component). Add support for these
> in the ingenic-drm driver.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 41 +++++++++++++++++------
> drivers/gpu/drm/ingenic/ingenic-drm.h | 1 +
> 2 files changed, 32 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index 937d080f5d06..fb62869befdc 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -49,6 +49,8 @@ struct jz_soc_info {
> bool needs_dev_clk;
> bool has_osd;
> unsigned int max_width, max_height;
> + const u32 *formats;
> + unsigned int num_formats;
> };
>
> struct ingenic_drm {
> @@ -73,12 +75,6 @@ struct ingenic_drm {
> bool no_vblank;
> };
>
> -static const u32 ingenic_drm_primary_formats[] = {
> - DRM_FORMAT_XRGB1555,
> - DRM_FORMAT_RGB565,
> - DRM_FORMAT_XRGB8888,
> -};
> -
> static bool ingenic_drm_cached_gem_buf;
> module_param_named(cached_gem_buffers, ingenic_drm_cached_gem_buf, bool, 0400);
> MODULE_PARM_DESC(cached_gem_buffers,
> @@ -411,6 +407,9 @@ void ingenic_drm_plane_config(struct device *dev,
> case DRM_FORMAT_XRGB8888:
> ctrl |= JZ_LCD_OSDCTRL_BPP_18_24;
> break;
> + case DRM_FORMAT_XRGB2101010:
> + ctrl |= JZ_LCD_OSDCTRL_BPP_30;
> + break;
> }
>
> regmap_update_bits(priv->map, JZ_REG_LCD_OSDCTRL,
> @@ -426,6 +425,9 @@ void ingenic_drm_plane_config(struct device *dev,
> case DRM_FORMAT_XRGB8888:
> ctrl |= JZ_LCD_CTRL_BPP_18_24;
> break;
> + case DRM_FORMAT_XRGB2101010:
> + ctrl |= JZ_LCD_CTRL_BPP_30;
> + break;
> }
>
> regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
> @@ -894,8 +896,8 @@ static int ingenic_drm_bind(struct device *dev, bool has_components)
>
> ret = drm_universal_plane_init(drm, &priv->f1, 1,
> &ingenic_drm_primary_plane_funcs,
> - ingenic_drm_primary_formats,
> - ARRAY_SIZE(ingenic_drm_primary_formats),
> + priv->soc_info->formats,
> + priv->soc_info->num_formats,
> NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
> if (ret) {
> dev_err(dev, "Failed to register plane: %i\n", ret);
> @@ -919,8 +921,8 @@ static int ingenic_drm_bind(struct device *dev, bool has_components)
>
> ret = drm_universal_plane_init(drm, &priv->f0, 1,
> &ingenic_drm_primary_plane_funcs,
> - ingenic_drm_primary_formats,
> - ARRAY_SIZE(ingenic_drm_primary_formats),
> + priv->soc_info->formats,
> + priv->soc_info->num_formats,
> NULL, DRM_PLANE_TYPE_OVERLAY,
> NULL);
> if (ret) {
> @@ -1121,11 +1123,26 @@ static int ingenic_drm_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const u32 jz4740_formats[] = {
> + DRM_FORMAT_XRGB1555,
> + DRM_FORMAT_RGB565,
> + DRM_FORMAT_XRGB8888,
> +};
> +
> +static const u32 jz4770_formats[] = {
> + DRM_FORMAT_XRGB1555,
> + DRM_FORMAT_RGB565,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_XRGB2101010,
> +};
> +
> static const struct jz_soc_info jz4740_soc_info = {
> .needs_dev_clk = true,
> .has_osd = false,
> .max_width = 800,
> .max_height = 600,
> + .formats = jz4740_formats,
> + .num_formats = ARRAY_SIZE(jz4740_formats),
> };
>
> static const struct jz_soc_info jz4725b_soc_info = {
> @@ -1133,6 +1150,8 @@ static const struct jz_soc_info jz4725b_soc_info = {
> .has_osd = true,
> .max_width = 800,
> .max_height = 600,
> + .formats = jz4740_formats,
> + .num_formats = ARRAY_SIZE(jz4740_formats),
> };
>
> static const struct jz_soc_info jz4770_soc_info = {
> @@ -1140,6 +1159,8 @@ static const struct jz_soc_info jz4770_soc_info = {
> .has_osd = true,
> .max_width = 1280,
> .max_height = 720,
> + .formats = jz4770_formats,
> + .num_formats = ARRAY_SIZE(jz4770_formats),
> };
>
> static const struct of_device_id ingenic_drm_of_match[] = {
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.h b/drivers/gpu/drm/ingenic/ingenic-drm.h
> index df99f0f75d39..f05e18e6b6fa 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.h
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.h
> @@ -124,6 +124,7 @@
> #define JZ_LCD_CTRL_BPP_8 0x3
> #define JZ_LCD_CTRL_BPP_15_16 0x4
> #define JZ_LCD_CTRL_BPP_18_24 0x5
> +#define JZ_LCD_CTRL_BPP_30 0x7
> #define JZ_LCD_CTRL_BPP_MASK (JZ_LCD_CTRL_RGB555 | 0x7)
>
> #define JZ_LCD_CMD_SOF_IRQ BIT(31)
> --
> 2.28.0

\
 
 \ /
  Last update: 2020-09-24 22:15    [W:0.150 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site