lkml.org 
[lkml]   [2020]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v1 3/3] dt-binding: display: Require two rests on mantix panel
Hi Guido.

On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido Günther wrote:
> We need to reset both for the panel to show an image.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> .../bindings/display/panel/mantix,mlaf057we51-x.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> index 937323cc9aaa..ba5a18fac9f9 100644
> --- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
> @@ -35,7 +35,9 @@ properties:
> vddi-supply:
> description: 1.8V I/O voltage supply
>
> - reset-gpios: true
> + reset-gpios:
> + minItems: 2
> + maxItems: 2

reset-gpios is, as you already wrote, defined in panel-common.yaml.
Do not try to change it here.
It would be much better, I think, to introduce a mantix,reset-gpios
property.

This would avoid that we had two different reset-gpios definitions.

Sam

>
> backlight: true
>
> @@ -62,7 +64,8 @@ examples:
> avdd-supply = <&reg_avdd>;
> avee-supply = <&reg_avee>;
> vddi-supply = <&reg_1v8_p>;
> - reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;
> + reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>,
> + <&gpio1 24 GPIO_ACTIVE_LOW>;
> backlight = <&backlight>;
> };
> };
> --
> 2.26.2

\
 
 \ /
  Last update: 2020-09-24 21:44    [W:0.093 / U:0.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site