lkml.org 
[lkml]   [2020]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/30] spi: dw: Use relaxed IO-methods to access FIFOs
    Date
    In accordance with [1] the relaxed methods are guaranteed to be ordered
    with respect to other accesses from the same CPU thread to the same
    peripheral. This is what we need during the data read/write from/to the
    controller FIFOs being executed within a single IRQ handler or a kernel
    task.

    Such optimization shall significantly speed the data reader and writer up.
    For instance, the relaxed IO-accessors utilization on Baikal-T1 lets the
    driver to support the SPI memory operations with bus frequency three-fold
    faster than if normal IO-accessors would be used.

    [1] "LINUX KERNEL MEMORY BARRIERS", Documentation/memory-barriers.txt,
    Section "KERNEL I/O BARRIER EFFECTS"

    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    ---
    drivers/spi/spi-dw.h | 18 ++++--------------
    1 file changed, 4 insertions(+), 14 deletions(-)

    diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h
    index ff77f39047ce..063fa1b1352d 100644
    --- a/drivers/spi/spi-dw.h
    +++ b/drivers/spi/spi-dw.h
    @@ -161,29 +161,19 @@ static inline u32 dw_readl(struct dw_spi *dws, u32 offset)
    return __raw_readl(dws->regs + offset);
    }

    -static inline u16 dw_readw(struct dw_spi *dws, u32 offset)
    -{
    - return __raw_readw(dws->regs + offset);
    -}
    -
    static inline void dw_writel(struct dw_spi *dws, u32 offset, u32 val)
    {
    __raw_writel(val, dws->regs + offset);
    }

    -static inline void dw_writew(struct dw_spi *dws, u32 offset, u16 val)
    -{
    - __raw_writew(val, dws->regs + offset);
    -}
    -
    static inline u32 dw_read_io_reg(struct dw_spi *dws, u32 offset)
    {
    switch (dws->reg_io_width) {
    case 2:
    - return dw_readw(dws, offset);
    + return readw_relaxed(dws->regs + offset);
    case 4:
    default:
    - return dw_readl(dws, offset);
    + return readl_relaxed(dws->regs + offset);
    }
    }

    @@ -191,11 +181,11 @@ static inline void dw_write_io_reg(struct dw_spi *dws, u32 offset, u32 val)
    {
    switch (dws->reg_io_width) {
    case 2:
    - dw_writew(dws, offset, val);
    + writew_relaxed(val, dws->regs + offset);
    break;
    case 4:
    default:
    - dw_writel(dws, offset, val);
    + writel_relaxed(val, dws->regs + offset);
    break;
    }
    }
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-09-20 13:31    [W:20.108 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site