[lkml]   [2020]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] net: openvswitch: pass NULL for unused parameters

On 9/1/20 1:11 PM, David Miller wrote:
> From:
> Date: Sun, 30 Aug 2020 14:26:30 -0700
>> Passing unused parameters is a waste.
> Poorly predicted branches are an even bigger waste.
> I'm not a big fan of this change and others have asked for performance
> analysis to be performed.
> So I'm not applying this as-is, sorry.

no worries.

I think these functions need a larger working over so the stats collecting are not in the core functions.

Thanks for giving it a look,


> It's also not great to see that CLANG can't make use of the caller's
> __always_unused directive to guide these warnings.

 \ /
  Last update: 2020-09-02 20:41    [W:0.119 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site