Messages in this thread |  | | Subject | Re: [PATCH v4 2/2] KVM: nSVM: implement ondemand allocation of the nested state | From | Paolo Bonzini <> | Date | Sat, 19 Sep 2020 17:09:09 +0200 |
| |
On 17/09/20 18:29, Sean Christopherson wrote: >> + vcpu->arch.efer = old_efer; >> + kvm_make_request(KVM_REQ_OUT_OF_MEMORY, vcpu); > I really dislike KVM_REQ_OUT_OF_MEMORY. It's redundant with -ENOMEM and > creates a huge discrepancy with respect to existing code, e.g. nVMX returns > -ENOMEM in a similar situation.
Maxim, your previous version was adding some error handling to kvm_x86_ops.set_efer. I don't remember what was the issue; did you have any problems propagating all the errors up to KVM_SET_SREGS (easy), kvm_set_msr (harder) etc.?
Paolo
|  |