lkml.org 
[lkml]   [2020]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpio: aspeed: fix ast2600 bank properties
On Thu, Sep 17, 2020 at 08:42:27AM +0930, Andrew Jeffery wrote:
>
>
> On Thu, 17 Sep 2020, at 06:12, rentao.bupt@gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> >
> > GPIO_U is mapped to the least significant byte of input/output mask, and
> > the byte in "output" mask should be 0 because GPIO_U is input only. All
> > the other bits need to be 1 because GPIO_V/W/X support both input and
> > output modes.
> >
> > Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the
> > according bits need to be 1 because GPIO_Y/Z support both input and
> > output modes.
> >
> > Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
> > Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
>
> Thanks Tao,
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

Thanks Andrew for the quick review.

Cheers,

Tao

\
 
 \ /
  Last update: 2020-09-18 06:20    [W:0.085 / U:9.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site