lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 06/13] cramfs: Tell the VFS that readpage was synchronous
Date
The cramfs readpage implementation was already synchronous, so use
AOP_UPDATED_PAGE to avoid cycling the page lock.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
fs/cramfs/inode.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c
index 912308600d39..7a642146c074 100644
--- a/fs/cramfs/inode.c
+++ b/fs/cramfs/inode.c
@@ -916,15 +916,14 @@ static int cramfs_readpage(struct file *file, struct page *page)
flush_dcache_page(page);
kunmap(page);
SetPageUptodate(page);
- unlock_page(page);
- return 0;
+ return AOP_UPDATED_PAGE;

err:
kunmap(page);
ClearPageUptodate(page);
SetPageError(page);
unlock_page(page);
- return 0;
+ return -EIO;
}

static const struct address_space_operations cramfs_aops = {
--
2.28.0
\
 
 \ /
  Last update: 2020-09-17 21:55    [W:0.099 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site