lkml.org 
[lkml]   [2020]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [RFC] openprom: Fix 'opiocnextprop'; ensure integer conversions; use string size
From
From: Michael Witten <mfwitten@gmail.com>
Date: Fri, 04 Sep 2020 19:40:00 -0000

> @@ -34,10 +34,10 @@ EXPORT_SYMBOL(of_console_options);
> int of_getintprop_default(struct device_node *np, const char *name, int def)
> {
> struct property *prop;
> - int len;
> + int size;
>
> - prop = of_find_property(np, name, &len);
> - if (!prop || len != 4)
> + prop = of_find_property(np, name, &size);
> + if (!prop || size != 4)
> return def;

This is just changing the variable name and makes no functional change
at all, and therefore is gratuitous.

Please only include pure functional changes that fix the bug(s) in
question.

If there are multiple bugs, please fix one bug per patch and include a
detailed explanation of each bug fix in the body of the commit
message.

Thank you.

\
 
 \ /
  Last update: 2020-09-15 02:04    [W:0.078 / U:2.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site