lkml.org 
[lkml]   [2020]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 1/4] gpio: mxc: Support module build
Date
Hi, Linus

> Subject: Re: [PATCH V2 1/4] gpio: mxc: Support module build
>
> On Thu, Sep 3, 2020 at 3:31 AM Anson Huang <anson.huang@nxp.com>
> wrote:
>
> > Hi, Linus
> > Do you have chance to take a look at this patch series?
>
> I've seen there was plenty discussion about them, like this one, so I expected a
> repost (didn't anything change at all?) also a rebase on v5.9-rc1 so I do not
> have to deal with any merge conflicts.

I went through the discussion again, the main concern is whether need to support
unload if the driver supports module build, but for SoC GPIO driver, as john said, it is
commonly used by peripheral devices, similar as clock, pinctrl driver, sorting out the
unloading is particularly complicated or there is some missing infrastructure, and in
those cases being able to load a "permanent" module seems to me like a clear benefit.

So I think the first step is to just enable it as "permanent" modules like pinctrl/clk driver,
as currently, most of the SoC GPIO users are NOT supporting module build at all, so the
unload support for SoC GPIO driver is NOT available currently.

>
> Could you rebase and resend?

I will rebase to latest linux-next and resend the patch series.

Thanks,
Anson
\
 
 \ /
  Last update: 2020-09-14 04:20    [W:0.075 / U:3.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site