lkml.org 
[lkml]   [2020]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf bench: Fix 2 memory sanitizer warnings
On Fri, Sep 11, 2020 at 10:37:25PM -0700, Ian Rogers wrote:
> Memory sanitizer warns if a write is performed where the memory
> being read for the write is uninitialized. Avoid this warning by
> initializing the memory.
>
> Signed-off-by: Ian Rogers <irogers@google.com>

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

> ---
> tools/perf/bench/sched-messaging.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/bench/sched-messaging.c b/tools/perf/bench/sched-messaging.c
> index 71d830d7b923..cecce93ccc63 100644
> --- a/tools/perf/bench/sched-messaging.c
> +++ b/tools/perf/bench/sched-messaging.c
> @@ -66,11 +66,10 @@ static void fdpair(int fds[2])
> /* Block until we're ready to go */
> static void ready(int ready_out, int wakefd)
> {
> - char dummy;
> struct pollfd pollfd = { .fd = wakefd, .events = POLLIN };
>
> /* Tell them we're ready. */
> - if (write(ready_out, &dummy, 1) != 1)
> + if (write(ready_out, "R", 1) != 1)
> err(EXIT_FAILURE, "CLIENT: ready write");
>
> /* Wait for "GO" signal */
> @@ -85,6 +84,7 @@ static void *sender(struct sender_context *ctx)
> unsigned int i, j;
>
> ready(ctx->ready_out, ctx->wakefd);
> + memset(data, 'S', sizeof(data));
>
> /* Now pump to every receiver. */
> for (i = 0; i < nr_loops; i++) {
> --
> 2.28.0.618.gf4bc123cb7-goog
>

\
 
 \ /
  Last update: 2020-09-12 22:52    [W:0.038 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site