lkml.org 
[lkml]   [2020]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: vidtv: fix 32-bit warnings
From
Date
On Sat, 2020-09-12 at 11:22 +0200, Mauro Carvalho Chehab wrote:
> There are several warnings produced when the driver is built
> for 32-bit archs. Solve them.
[]
> diff --git a/drivers/media/test-drivers/vidtv/vidtv_common.c b/drivers/media/test-drivers/vidtv/vidtv_common.c
[]
> diff --git a/drivers/media/test-drivers/vidtv/vidtv_pes.c b/drivers/media/test-drivers/vidtv/vidtv_pes.c
[]
> @@ -91,13 +91,13 @@ static u32 vidtv_pes_write_pts_dts(struct pes_header_write_args args)
> return 0;
>
> #ifdef __BIG_ENDIAN
> - mask1 = GENMASK(30, 32);
> - mask2 = GENMASK(15, 29);
> - mask3 = GENMASK(0, 14);
> + mask1 = GENMASK_ULL(30, 32);
> + mask2 = GENMASK_ULL(15, 29);
> + mask3 = GENMASK_ULL(0, 14);

These are broken as GENMASK_ULL takes arguments
in high then low order.

> #else
> - mask1 = GENMASK(32, 30);
> - mask2 = GENMASK(29, 15);
> - mask3 = GENMASK(14, 0);
> + mask1 = GENMASK_ULL(32, 30);
> + mask2 = GENMASK_ULL(29, 15);
> + mask3 = GENMASK_ULL(14, 0);
> #endif

The #ifdef can be removed instead.


\
 
 \ /
  Last update: 2020-09-12 21:53    [W:0.036 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site