Messages in this thread Patch in this message |  | | From | trix@redhat ... | Subject | [PATCH] staging: wfx: simplify virt_addr_valid call | Date | Sat, 12 Sep 2020 07:47:19 -0700 |
| |
From: Tom Rix <trix@redhat.com>
Reviewing sram_write_dma_safe(), there are two identical calls to virt_addr_valid(). The second call can be simplified by a comparison of variables set from the first call.
Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/staging/wfx/fwio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/fwio.c b/drivers/staging/wfx/fwio.c index 22d3b684f04f..c99adb0c99f1 100644 --- a/drivers/staging/wfx/fwio.c +++ b/drivers/staging/wfx/fwio.c @@ -94,7 +94,7 @@ static int sram_write_dma_safe(struct wfx_dev *wdev, u32 addr, const u8 *buf, tmp = buf; } ret = sram_buf_write(wdev, addr, tmp, len); - if (!virt_addr_valid(buf)) + if (tmp != buf) kfree(tmp); return ret; } -- 2.18.1
|  |