lkml.org 
[lkml]   [2020]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 02/25] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen
On Tue, 8 Sep 2020 at 22:25, Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Sep 07, 2020 at 06:11:18PM +0200, Krzysztof Kozlowski wrote:
> > The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch
> > screen. In such case the second interrupt is required. This second
> > interrupt can be anyway provided, even without touch screens. This
> > fixes dtbs_check warnings like:
> >
> > arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too long
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > .../bindings/iio/adc/samsung,exynos-adc.yaml | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> > index cc3c8ea6a894..89b4f9c252a6 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> > @@ -41,7 +41,10 @@ properties:
> > maxItems: 2
> >
> > interrupts:
> > - maxItems: 1
> > + description:
> > + ADC interrupt followed by optional touchscreen interrupt.
> > + minItems: 1
> > + maxItems: 2
> >
> > "#io-channel-cells":
> > const: 1
> > @@ -107,6 +110,16 @@ allOf:
> > items:
> > - const: adc
> >
> > + - if:
> > + properties:
> > + has-touchscreen:
> > + true
>
> This evaluates as true if 'has-touchscreen' is not present too. You
> should use 'required' here.

I see, thanks. I'll send a v2.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2020-09-10 13:59    [W:0.160 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site