lkml.org 
[lkml]   [2020]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next v7 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices
On Thu, Sep 10, 2020 at 11:25 AM Vadym Kochan <vadym.kochan@plvision.eu> wrote:
> On Fri, Sep 04, 2020 at 10:12:07PM +0300, Andy Shevchenko wrote:
> > On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan <vadym.kochan@plvision.eu> wrote:


> > > + .param = {.admin_state = admin_state}
> >
> > + white spaces? Whatever you choose, just be consistent among all
> > similar definitions.
> >
>
> Can I use following format for one-liner embedded struct ?

Of course. It's just a style matter.
My point that you need to be consistent over all similar cases in the code.

> .param = {
> .admin_state = admin_state,
> }
> > ...
> >
>
> I think it looks better when all of the members filled looks similar
> (even if it requires 2 additional lines) instead of having:
>
> .member = { E } ?

I like the former one (as you do), but in some cases when you have one
member or an array it's convenient to have them one one line.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-09-10 13:59    [W:0.190 / U:5.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site