lkml.org 
[lkml]   [2020]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 1/5] mm, page_alloc: clean up pageset high and batch update
On Thu, Sep 10, 2020 at 10:31:20AM +0200, Oscar Salvador wrote:
> On Mon, Sep 07, 2020 at 06:36:24PM +0200, Vlastimil Babka wrote:
> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
>
> > for_each_possible_cpu(cpu)
> > - setup_pageset(&per_cpu(boot_pageset, cpu), 0);
> > + setup_pageset(&per_cpu(boot_pageset, cpu));
>
> This is not really anything important but I realized we have like 7 functions
> messing with pcp lists, and everytime I try to follow them my head spins.
>
> Since setup_pageset is only being called here, could we replace it by the
> pageset_init and pageset_update?
>
> (As I said, not important and probably a matter of taste. I just think that
> having so many mini functions around is not always cool,
> e.g: setup_zone_pageset->zone_pageset_init)

Sorry, I did not see that you just did that in Patch#3, bleh.


--
Oscar Salvador
SUSE L3

\
 
 \ /
  Last update: 2020-09-10 10:36    [W:0.106 / U:3.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site