lkml.org 
[lkml]   [2020]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 10/24] ioctl_ns.2: Remove unneeded cast
Date
Both major(3) and minor(3) return an 'unsigned int',
so there is no need to use a 'long' for printing.
Moreover, it should have been 'unsigned long',
as "%lx" expects an unsigned type.

Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
---
man2/ioctl_ns.2 | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/man2/ioctl_ns.2 b/man2/ioctl_ns.2
index 818dde32c..bf832a2c7 100644
--- a/man2/ioctl_ns.2
+++ b/man2/ioctl_ns.2
@@ -316,9 +316,8 @@ main(int argc, char *argv[])
exit(EXIT_FAILURE);
}
printf("Device/Inode of owning user namespace is: "
- "[%lx,%lx] / %ld\en",
- (long) major(sb.st_dev), (long) minor(sb.st_dev),
- (long) sb.st_ino);
+ "[%x,%x] / %ld\en",
+ major(sb.st_dev), minor(sb.st_dev), (long) sb.st_ino);

close(userns_fd);
}
@@ -345,9 +344,8 @@ main(int argc, char *argv[])
perror("fstat\-parentns");
exit(EXIT_FAILURE);
}
- printf("Device/Inode of parent namespace is: [%lx,%lx] / %ld\en",
- (long) major(sb.st_dev), (long) minor(sb.st_dev),
- (long) sb.st_ino);
+ printf("Device/Inode of parent namespace is: [%x,%x] / %ld\en",
+ major(sb.st_dev), minor(sb.st_dev), (long) sb.st_ino);

close(parent_fd);
}
--
2.28.0
\
 
 \ /
  Last update: 2020-09-10 23:17    [W:0.394 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site