Messages in this thread Patch in this message |  | | From | Qi Zheng <> | Subject | [PATCH] sched/fair: Remove the duplicate check from group_has_capacity() | Date | Mon, 10 Aug 2020 09:00:09 +0800 |
| |
1. The group_has_capacity() function is only called in group_classify(). 2. The following inequality has already been checked in group_is_overloaded() which was also called in group_classify().
(sgs->group_capacity * imbalance_pct) < (sgs->group_runnable * 100)
So just remove the duplicate check from group_has_capacity().
Signed-off-by: Qi Zheng <arch0.zheng@gmail.com> --- kernel/sched/fair.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 2ba8f230feb9..a41903fb327a 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8234,10 +8234,6 @@ group_has_capacity(unsigned int imbalance_pct, struct sg_lb_stats *sgs) if (sgs->sum_nr_running < sgs->group_weight) return true; - if ((sgs->group_capacity * imbalance_pct) < - (sgs->group_runnable * 100)) - return false; - if ((sgs->group_capacity * 100) > (sgs->group_util * imbalance_pct)) return true; -- 2.25.1
|  |