lkml.org 
[lkml]   [2020]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 1/4] scsi: ufs: Add UFS feature related parameter
From
Date
On 2020-08-06 02:02, Daejun Park wrote:
> @@ -537,6 +548,7 @@ struct ufs_dev_info {
> u8 *model;
> u16 wspecversion;
> u32 clk_gating_wait_us;
> + u8 b_ufs_feature_sup;
> u32 d_ext_ufs_feature_sup;
> u8 b_wb_buffer_type;
> u32 d_wb_alloc_units;
>

Hmm ... shouldn't this variable be introduced in the patch that introduces
the code that sets and uses this variable?

How about making it clear in the patch subject that this patch adds protocol
constants related to HPB?

Otherwise this patch looks good to me.

Bart.

\
 
 \ /
  Last update: 2020-08-09 01:00    [W:0.281 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site