lkml.org 
[lkml]   [2020]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> Hi Krzysztof,
>
> On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
> > The camera's pinctrl configuration is simply empty and not effective.
> > Remove it to fix dtbs_check warning:
> >
> > arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> I think that this was intentional to properly enable support for
> mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the
> default values if no pinctrl properties are provided. Sylwester, could
> you comment?

Indeed it could be intentional... I see now errors:
[ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19

I wonder why getting an empty pinctrl is needed... maybe the driver
should accept missing pinctrl?

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2020-08-31 10:40    [W:0.064 / U:1.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site