[lkml]   [2020]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] clk: versatile: Add of_node_put() before return statement
On Sat, Aug 29, 2020 at 7:57 PM Sumera Priyadarsini
<> wrote:

> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
> Fix a potential memory leak in clk-impd1.c by inserting
> of_node_put() before a return statement.
> Issue found with Coccinelle.
> Signed-off-by: Sumera Priyadarsini <>

Reviewed-by: Linus Walleij <>

Linus Walleij

 \ /
  Last update: 2020-08-30 12:08    [W:0.038 / U:4.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site