Messages in this thread |  | | Date | Sun, 30 Aug 2020 09:10:04 +0100 | From | Sean Young <> | Subject | Re: [PATCH v1] [media] netup_unidvb: use generic power management |
| |
On Tue, Jul 28, 2020 at 02:57:17PM +0530, Vaibhav Gupta wrote: > The .suspend() and .resume() callbacks are not defined for this driver. > Still, their power management structure follows the legacy framework. To > bring it under the generic framework, simply remove the binding of > callbacks from "struct pci_driver".
Unlisted fields in a static struct initializer will get set to 0 (or NULL for pointers) already. Removing the NULL initializers will not change anything.
Possibly you want to remove the redundant initializers but your commit message should say so.
Sean
> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> > --- > drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c > index 80a7c41baa90..6f3125c2d097 100644 > --- a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c > +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c > @@ -1016,8 +1016,6 @@ static struct pci_driver netup_unidvb_pci_driver = { > .id_table = netup_unidvb_pci_tbl, > .probe = netup_unidvb_initdev, > .remove = netup_unidvb_finidev, > - .suspend = NULL, > - .resume = NULL, > }; > > module_pci_driver(netup_unidvb_pci_driver); > -- > 2.27.0
|  |