lkml.org 
[lkml]   [2020]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [EXT] [PATCH] bnx2x: correct a mistake when show error code
From
Date

> drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> index 1426c691c7c4..0346771396ce 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> @@ -13562,9 +13560,8 @@ static int bnx2x_ext_phy_common_init(struct bnx2x
> *bp, u32 shmem_base_path[],
> }
>
> if (rc)
> - netdev_err(bp->dev, "Warning: PHY was not initialized,"
> - " Port %d\n",
> - 0);
> + netdev_err(bp->dev, "Warning: PHY was not initialized, Port %d\n",
> + rc);
> return rc;

Hi Yi,

Thanks, but if you want to report rc in this trace - then state "rc = %d"
explicitly in the string. Because now its "Port %d" but you put error code in
there...

Thanks,
Igor

\
 
 \ /
  Last update: 2020-08-30 09:59    [W:0.038 / U:7.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site