lkml.org 
[lkml]   [2020]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mm/memory-failure: Fix return wrong value when isolate page fail
Date
On Sun, Aug 30, 2020 at 03:44:18PM -0400, Qian Cai wrote:
> On Sun, Aug 30, 2020 at 04:10:53PM +0800, Muchun Song wrote:
> > When we isolate page fail, we should not return 0, because we do not
> > set page HWPoison on any page.
> >
> > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>
> This seems solve the problem for me that madvise(MADV_SOFT_OFFLINE) will run
> into ENOMEM eventually:
>
> https://lore.kernel.org/lkml/20200811220643.GB39857@lca.pw/
>
> Reviewed-by: Qian Cai <cai@lca.pw>

Thank you very much, both of you!

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

> > ---
> > mm/memory-failure.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> > index 696505f56910..4eb3c42ffe35 100644
> > --- a/mm/memory-failure.c
> > +++ b/mm/memory-failure.c
> > @@ -1850,6 +1850,7 @@ static int __soft_offline_page(struct page *page)
> > } else {
> > pr_info("soft offline: %#lx: %s isolation failed: %d, page count %d, type %lx (%pGp)\n",
> > pfn, msg_page[huge], ret, page_count(page), page->flags, &page->flags);
> > + ret = -EBUSY;
> > }
> > return ret;
> > }
> > --
> > 2.11.0
> >
> >
>
\
 
 \ /
  Last update: 2020-08-31 00:29    [W:0.046 / U:30.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site