[lkml]   [2020]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 06/11] kconfig: qconf: allow to edit "int", "hex", "string" menus in-place
On 8/29/20 1:14 AM, Masahiro Yamada wrote:
> Previously, when you double-clicked the "int", "hex", or "string" menus,
> a line-edit gadget showed up to allow you to input the value, which
> looked clumsy.
> Also, it was buggy; the editor opened even if the config option was not
> editable. For example, just try to double-click CC_VERSION_TEXT, which
> has no prompt.
> This commit sub-classes QStyleItemDelegate to allow users to edit
> "int", "hex", "string" menus in-place. Just double-click (or press
> the F2 key) in the data column. Then, an editor widget is placed on
> top of the item view.

The F2 key doesn't work for me. I guess that's a desktop environment
issue (I am using Xfce).

> The two methods are overridden:
> createEditor - process only when the data column is being accessed
> and the menu is visible. Otherwise, return nullptr to disallow editing.
> setModelData - take the new data from the editor, and set it to the
> addressed symbol. If it was successful, update all the list windows.
> Otherwise, (the reason for the failure is possibly the input data was
> out of range), set the old value back to the editor.
> Signed-off-by: Masahiro Yamada <>
> ---
> scripts/kconfig/ | 93 ++++++++++++++++++++++++++++++++--------
> scripts/kconfig/qconf.h | 15 +++++++
> 2 files changed, 91 insertions(+), 17 deletions(-)


 \ /
  Last update: 2020-08-30 06:54    [W:0.103 / U:3.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site