lkml.org 
[lkml]   [2020]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ubifs: setflags: Don't show error message when vfs_ioc_setflags_prepare() fails
On Fri, Aug 28, 2020 at 5:33 AM Zhihao Cheng <chengzhihao1@huawei.com> wrote:
>
> Following process will trigger ubifs_err:
> 1. useradd -m freg (Under root)
> 2. cd /home/freg && mkdir mp (Under freg)
> 3. mount -t ubifs /dev/ubi0_0 /home/freg/mp (Under root)
> 4. cd /home/freg && echo 123 > mp/a (Under root)
> 5. cd mp && chown freg a && chgrp freg a && chmod 777 a (Under root)
> 6. chattr +i a (Under freg)
>
> UBIFS error (ubi0:0 pid 1723): ubifs_ioctl [ubifs]: can't modify inode
> 65 attributes
> chattr: Operation not permitted while setting flags on a
>
> This is not an UBIFS problem, it was caused by task priviliage checking
> on file operations. Remove error message printing from kernel just like
> other filesystems (eg. ext4), since we already have enough information
> from userspace tools.
>
> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> ---
> fs/ubifs/ioctl.c | 1 -
> 1 file changed, 1 deletion(-)

Makes sense, thanks for fixing!
BTW: I didn't forget about the other valuable fixes from you, in the
next two weeks I'll hopefully
find more time for reviewing/testing. :-)

--
Thanks,
//richard

\
 
 \ /
  Last update: 2020-08-30 21:25    [W:0.044 / U:12.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site