Messages in this thread |  | | Date | Fri, 28 Aug 2020 10:15:21 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v6 2/2] mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller |
| |
On Fri, 10 Jul 2020, Lubomir Rintel wrote:
> This driver provides access to the EC RAM of said embedded controller > attached to the I2C bus as well as optionally supporting its slightly weird > power-off/restart protocol. > > A particular implementation of the EC firmware can be identified by a > model byte. If this driver identifies the Dell Ariel platform, it > registers the appropriate cells. > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > > --- > Changes since v5: > - Clarify the command in kb3930_off() > - Remove an extraneous comment above the call to devm_mfd_add_devices() > - s/pm_power_off == NULL/!pm_power_off/ > > Changes since v3: > - Clarify that the power-off function is provided by this driver while > LEDS_ARIEL is necessary to drive the leds in Kconfig help text > - s/kb3930_power_off/kb3930_pm_power_off/, s/global_kb3930/kb3930_power_off/ > - Don't fail with -EEXIST with more than one instance > - s/ret < 0/ret/ for devm_mfd_add_devices() return value > - Drop a \n between struct i2c_driver and module_i2c_driver() > > Changes since v2: > - Sort the includes > - s/EC_MODEL_ID/EC_MODEL/ > - Add a couple of clarifying comments > - Use #defines for values used in poweroff routine > - Remove priority from a restart notifier block > - s/priv/ddata/ > - s/ec_ram/ram_regmap/ for the regmap name > - Fix the error handling when getting off gpios was not successful > - Remove a useless dev_info at the end of probe() > - Use i2c probe_new() callback, drop i2c_device_id > - Modify the logic in checking the model ID > --- > drivers/mfd/Kconfig | 11 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/ene-kb3930.c | 212 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 224 insertions(+) > create mode 100644 drivers/mfd/ene-kb3930.c
Applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
|  |