lkml.org 
[lkml]   [2020]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] genirq/proc: Show percpu irq affinity
From
Date


On 2020/8/22 19:35, Thomas Gleixner wrote:
> On Sat, Aug 22 2020 at 17:33, Yunfeng Ye wrote:
>> On 2020/8/13 16:27, Thomas Gleixner wrote:
>> For example, the cmdline "irqaffinity=0,1,126,127" on the 128 cores system:
>>
>> [root@localhost ~]# cat /proc/irq/4/smp_affinity_list
>> 0-1,126-127
>>
>> The irq 4 is "arch_timer" interrupt, which is a percpu interrupt.
>>
>> So is it necessary to show the percpu irq affinity correct?
>
> Yes, it makes sense to do so, but you used the wrong check. The correct
> one is:
>
> irq_settings_is_per_cpu_devid()
>
> which will not wreckage the output for other per cpu marked interrupts
> which never set the percpu_affinity pointer with the obvious
> consequences... The pointer would need a NULL check in any case, but it
> might be more straight forward to update affinity when percpu_affinity
> is initialized. Haven't looked in detail though.
>
ok, I will send the patch v2, thanks.

> Thanks,
>
> tglx
>
> .
>

\
 
 \ /
  Last update: 2020-08-25 11:40    [W:0.082 / U:2.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site