[lkml]   [2020]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 2/2] x86/resctrl: Enable user to view thread or core throttling mode
On Fri, Aug 21, 2020 at 11:25:17AM -0700, Fenghua Yu wrote:
> Early Intel hardware implementations of Memory Bandwidth Allocation (MBA)
> could only control bandwidth at the processor core level. This meant that
> when two processes with different bandwidth allocations ran simultaneously
> on the same core the hardware had to resolve this difference. It did so by
> applying the higher throttling value (lower bandwidth) to both processes.
> Newer implementations can apply different throttling values to each
> thread on a core.
> Introduce a new resctrl file, "thread_throttle_mode", on Intel systems
> that shows to the user how throttling values are allocated, per-core or
> per-thread.
> On systems that support per-core throttling, the file will display "max".
> On newer systems that support per-thread throttling, the file will display
> "per-thread".
> AMD confirmed in
> that AMD bandwidth allocation is already at thread level but that the AMD
> implementation does not use a memory delay throttle mode. So to avoid
> confusion the thread throttling mode would be UNDEFINED on AMD systems
> and the "thread_throttle_mode" file will not be visible.
> Originally-by: Reinette Chatre <>
> Signed-off-by: Fenghua Yu <>
> Reviewed-by: Reinette Chatre <>
> ---
> Change log:
> v2:
> - Rename "arch_throttle_mode" to "throttle_mode" and
> "rdtgroup_rftype_by_name()" to "rdtgroup_rftype_get_by_name()" (Boris).

But you didn't call it that. You called it:


Two "get" and the prefix doesn't come first. So take this string


and paste it everywhere where the function name is.

How about you slow down, do it right and then send it? It is not a
competition where the first to send, wins.

Also, pls redo the patches ontop of tip:x86/cache because there's James'
stuff there now and this one doesn't apply.

And test them again and *then* resend.



 \ /
  Last update: 2020-08-22 11:02    [W:0.055 / U:4.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site