lkml.org 
[lkml]   [2020]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/20] ALSA: hda/ca0132 - Add bass redirection controls.
On Fri, 21 Aug 2020 20:52:22 +0200,
Connor McAdams wrote:
>
> +static int ca0132_alt_add_bass_redirection_crossover(struct hda_codec *codec)
> +{
> + const char *namestr = "Output: Bass Redirection Playback Volume";
> + struct snd_kcontrol_new knew =
> + HDA_CODEC_VOLUME_MONO(namestr, BASS_REDIRECTION_XOVER, 1, 0,
> + HDA_OUTPUT);

This is no ideal name string for a control element, too.
Better to omit "Output:" prefix at least.


thanks,

Takashi

\
 
 \ /
  Last update: 2020-08-22 18:18    [W:0.067 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site