lkml.org 
[lkml]   [2020]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH V3] iomap: add support to track dirty state of sub pages
On Thu, Aug 20, 2020 at 09:38:53AM +0800, yukuai (C) wrote:
> > > +iomap_set_range_dirty(struct page *page, unsigned int off,
> > > + unsigned int len)
> > > +{
> > > + if (PageError(page))
> > > + return;
> > > +
> > > + if (page_has_private(page))
> > > + iomap_iop_set_range_dirty(page, off, len);
> >
> >
> > I vaguely remembered iomap doesn't always set up PagePrivate.
> >
>
> If so, maybe I should move iomap_set_page_dirty() to
> ioamp_set_range_dirty().

iomap sets PagePrivate if a iomap_page structure is allocated. Right
now that means for all pages on a file system with a block size smaller
than the page size, although I hope we reduce that scope a little.

\
 
 \ /
  Last update: 2020-08-21 08:13    [W:0.062 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site