lkml.org 
[lkml]   [2020]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL v2] MFD for v5.9
On Fri, Aug 14, 2020 at 7:42 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Here is the new pull request. It has been tested; locally, by
> TuxBuild and the Intel 'kernel test robot' [0]. Please consider this for
> addition into v5.9. All of these patches have also soak tested in
> -next for a considerable amount of time.

I'm extremely annoyed by this all, but I've pulled this.

Please just *STOP* doing any W=1 fixes (and most definitely W=2 ones -
many of those warnings are just plain garbage and indicate more about
the compiler than they do about the code) if you can't then make damn
sure that the warnings that actually matter are always *ALWAY* taken
care of.

I absolutely abhor warnings in the default build, just because they
only result in people ignoring them. Which is exactly what happened
bvecause you then tried to care about the more-or-less worthless W=1
ones.

So a clean build is really important to me. And developers who don't
check and follow up on warnings in the normal build are something that
pisses me off no end.

Now something like 25 commits are pointlessly rebased just because you
didn't check warnings properly.

Linus

\
 
 \ /
  Last update: 2020-08-15 23:53    [W:0.135 / U:1.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site