lkml.org 
[lkml]   [2020]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10 2/5] drm/msm/dp: add displayPort driver support
From
Date
Hello,

On 12/08/2020 07:42, Tanmay Shah wrote:
> From: Chandan Uddaraju <chandanu@codeaurora.org>

[skipped]

> + } else if ((dp_parser_check_prefix("ctrl", clk_name) ||
> + dp_parser_check_prefix("stream", clk_name)) &&
> + ctrl_clk_index < ctrl_clk_count) {
> + struct dss_clk *clk =
> + &ctrl_power->clk_config[ctrl_clk_index];
> + strlcpy(clk->clk_name, clk_name, sizeof(clk->clk_name));
> + ctrl_clk_index++;
> +
> + if (!strncmp(clk_name, "ctrl_link",
> + strlen("ctrl_link")) ||
> + !strncmp(clk_name, "stream_pixel",
> + strlen("ctrl_pixel")))

This should be "stream_pixel", I believe. I don't like macros, but most
probably it would help here. Also function/brace alignment could be
better (sorry, it really hides the issue here).


> + clk->type = DSS_CLK_PCLK;
> + else
> + clk->type = DSS_CLK_AHB;
> + }
> + }


--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2020-08-14 19:12    [W:0.236 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site