lkml.org 
[lkml]   [2020]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH net] bonding: show saner speed for broadcast mode
    On Thu, Aug 13, 2020 at 1:30 AM Jay Vosburgh <jay.vosburgh@canonical.com> wrote:
    >
    > Jarod Wilson <jarod@redhat.com> wrote:
    >
    > >Broadcast mode bonds transmit a copy of all traffic simultaneously out of
    > >all interfaces, so the "speed" of the bond isn't really the aggregate of
    > >all interfaces, but rather, the speed of the lowest active interface.
    >
    > Did you mean "slowest" here?

    I think I was thinking "lowest speed", but the way it's written does
    seem a little ambiguous, and slowest would fit better. I'll repost
    with slowest.

    > >Also, the type of the speed field is u32, not unsigned long, so adjust
    > >that accordingly, as required to make min() function here without
    > >complaining about mismatching types.
    > >
    > >Fixes: bb5b052f751b ("bond: add support to read speed and duplex via ethtool")
    > >CC: Jay Vosburgh <j.vosburgh@gmail.com>
    > >CC: Veaceslav Falico <vfalico@gmail.com>
    > >CC: Andy Gospodarek <andy@greyhouse.net>
    > >CC: "David S. Miller" <davem@davemloft.net>
    > >CC: netdev@vger.kernel.org
    > >Signed-off-by: Jarod Wilson <jarod@redhat.com>
    >
    > Did you notice this by inspection, or did it come up in use
    > somewhere? I can't recall ever hearing of anyone using broadcast mode,
    > so I'm curious if there is a use for it, but this change seems
    > reasonable enough regardless.

    Someone working on our virt management tools was working on something
    displaying bonding speeds in the UI, and reached out, thinking the
    reporting for broadcast mode was wrong. My response was similar: I
    don't think I've ever actually used broadcast mode or heard of anyone
    using it, but for that one person who does, sure, we can probably make
    that adjustment. :)

    --
    Jarod Wilson
    jarod@redhat.com

    \
     
     \ /
      Last update: 2020-08-13 16:08    [W:21.795 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site