lkml.org 
[lkml]   [2020]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings
Hi Prabhakar, Laurent, Kieran,

On Wed, Aug 12, 2020 at 4:02 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
>
> Document the RZ/G2H (a.k.a. r8a774e1) SoC in the R-Car DU bindings.
>
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
> index 51cd4d162770..67cded5ad827 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -10,6 +10,7 @@ Required Properties:
> - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU
> - "renesas,du-r8a774b1" for R8A774B1 (RZ/G2N) compatible DU
> - "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU
> + - "renesas,du-r8a774e1" for R8A774E1 (RZ/G2H) compatible DU
> - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
> - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
> @@ -75,6 +76,7 @@ corresponding to each DU output.
> R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 -
> R8A774B1 (RZ/G2N) DPAD 0 HDMI 0 LVDS 0 -
> R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 -
> + R8A774E1 (RZ/G2H) DPAD 0 HDMI 0 LVDS 0 -

As LVDS 0 is the fourth channel (DU3), should it be listed under port 3
instead of port 2?

I know we did it the same for R-Car M3-N and RZ/G2N.
But my main worry is adding support for R-Car H3-N later.

> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
> R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
> R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - -

Apart from that:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2020-08-13 11:06    [W:0.161 / U:21.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site